[core] Support Table API in RESTCatalog #4736
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Dec 18, 2024
|
|
||
| import static org.apache.paimon.options.CatalogOptions.CASE_SENSITIVE; | ||
| import static org.apache.paimon.utils.ThreadPoolUtils.createScheduledThreadPool; | ||
|
|
||
| /** A catalog implementation for REST. */ | ||
| public class RESTCatalog implements Catalog { | ||
| public class RESTCatalog extends AbstractCatalog { |
There was a problem hiding this comment.
It is OK to let it be a new Catalog instead of AbstractCatalog.
AbstractCatalog has many designs for filesystem and hive only. We can have a new implementation.
jerry-024
force-pushed
the
rest-catalog
branch
from
a54b17e to
a90c527
Compare
…base for database api
JingsongLi
reviewed
Dec 19, 2024
| @@ -433,6 +435,27 @@ public ProcessSystemDatabaseException() { | |||
| } | |||
| } | |||
|
|
|||
| /** Exception for trying to operate on a table that doesn't have permission. */ | |||
| class TableNoPermissionException extends Exception { | |||
There was a problem hiding this comment.
Maybe it is better to be a RuntimeException? It is better to not bother method interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support Table API in RESTCatalog
Linked issue: #4715 and #4540
Tests
API and Format
Documentation