Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hive] Close metastore clients in hive catalog #4733

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import java.util.function.Supplier;

/** Client pool for using multiple clients to execute actions. */
public interface ClientPool<C, E extends Exception> {
public interface ClientPool<C, E extends Exception> extends Closeable {
/** Action interface with return object for client. */
interface Action<R, C, E extends Exception> {
R run(C client) throws E;
Expand All @@ -42,7 +42,7 @@ interface ExecuteAction<C, E extends Exception> {
void execute(ExecuteAction<C, E> action) throws E, InterruptedException;

/** Default implementation for {@link ClientPool}. */
abstract class ClientPoolImpl<C, E extends Exception> implements Closeable, ClientPool<C, E> {
abstract class ClientPoolImpl<C, E extends Exception> implements ClientPool<C, E> {

private volatile LinkedBlockingDeque<C> clients;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1017,7 +1017,7 @@ public void repairTable(Identifier identifier) throws TableNotExistException {

@Override
public void close() throws Exception {
// do nothing
clients.close();
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,14 @@ static Key extractKey(String clientClassName, String cacheKeys, Configuration co
return Key.of(elements);
}

@Override
public void close() throws IOException {
if (clientPoolCache != null) {
clientPoolCache.asMap().values().forEach(HiveClientPool::close);
clientPoolCache.cleanUp();
}
}

static class Key {
private final List<Object> elements;

Expand Down
Loading