-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Refactor MetastoreClient methods to simplify catalog #4726
[core] Refactor MetastoreClient methods to simplify catalog #4726
Conversation
}); | ||
if (metastoreClient != null && partitions.size() > 0) { | ||
try { | ||
metastoreClient.addPartitions( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addPartitions?not dropPartitions?
@@ -64,7 +57,7 @@ public PartitionStatisticsReporter(FileStoreTable table, MetastoreClient client) | |||
this.snapshotManager = table.snapshotManager(); | |||
} | |||
|
|||
public void report(String partition, long modifyTime) throws Exception { | |||
public void report(String partition, long modifyTimeMillis) throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modifyTimeInMillis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See System.currentTimeMillis
Partition hivePartition; | ||
List<String> partitionValues = new ArrayList<>(partition.values()); | ||
|
||
Map<String, String> statistic = new HashMap<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Map<String, String> statistic = new HashMap<>(5);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these small collection, we don't need to specific the init size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose
New MetastoreClient API:
Tests
API and Format
Documentation