Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove Catalog.getTableLocation interface #4718

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[core] Remove Catalog.getTableLocation interface #4718

merged 2 commits into from
Dec 16, 2024

Conversation

JingsongLi
Copy link
Contributor

Purpose

Catalog should not provide some interfaces to expose location, the location is an internal concept for Paimon table.

  1. CopyFileOperator use getTable to get table path.
  2. Like [hive][spark] Support creating external table without schema when the table already exists #4638 , Flink also support external table to avoid using getTableLocation.
  3. Remove Catalog.getTableLocation interface.

Tests

API and Format

Documentation

yuzelin
yuzelin approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@yuzelin yuzelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 7767020 into apache:master Dec 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzelin yuzelin yuzelin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JingsongLi @yuzelin