[flink] kafka_sync_database supports different prefix and suffix for different db #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Dec 13, 2024
| @@ -143,7 +143,8 @@ protected void beforeBuildingSourceSink() throws Exception { | |||
| for (JdbcTableInfo tableInfo : jdbcTableInfos) { | |||
| Identifier identifier = | |||
| Identifier.create( | |||
| database, tableNameConverter.convert(tableInfo.toPaimonTableName())); | |||
| database, | |||
| tableNameConverter.convert("", tableInfo.toPaimonTableName())); | |||
There was a problem hiding this comment.
Actually, I changed nothing but supply default value for the first argument of the "convert" method.
In this context, the prefix and suffix are not specified by database, so it's ok to provide an empty string as the argument value.
JingsongLi
reviewed
Dec 13, 2024
| @@ -529,6 +529,7 @@ under the License. | |||
| <exclude>release/**</exclude> | |||
| <!-- antlr grammar files --> | |||
| <exclude>paimon-common/src/main/antlr4/**</exclude> | |||
| <exclude>paimon-core/src/test/resources/compatibility/**</exclude> | |||
There was a problem hiding this comment.
If not, the rat-plugin always report license warning when building locally as the following:
[WARNING] Files with unapproved licenses:
paimon-core/src/test/resources/compatibility/datasplit-v1
paimon-core/src/test/resources/compatibility/datasplit-v2
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4703
With kafka_sync_database, user can specify different prefix and suffix for different db.
Tests
org.apache.paimon.flink.action.cdc.TableNameConverterTest#testConvertTableNameByDBPrefix_Suffix
API and Format
No
Documentation
Yes and provided.