[core] Retry if snapshot commit hint failed. #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Dec 13, 2024
| @@ -44,4 +44,19 @@ public static FileIOLoader checkAccess(FileIOLoader fileIO, Path path, CatalogCo | |||
| io.exists(path); | |||
| return fileIO; | |||
| } | |||
|
|
|||
| public static void overwriteFileUtf8WithRetry( | |||
There was a problem hiding this comment.
inline this in commitHint
JingsongLi
reviewed
Dec 13, 2024
| fileIO.overwriteFileUtf8(path, content); | ||
| return; | ||
| } catch (IOException e) { | ||
| if (loopTime == 0) { |
There was a problem hiding this comment.
Sleep a random value here?
xuzifu666
reviewed
Dec 13, 2024
| @@ -883,6 +884,6 @@ public void commitEarliestHint(long snapshotId) throws IOException { | |||
|
|
|||
| private void commitHint(long snapshotId, String fileName, Path dir) throws IOException { | |||
| Path hintFile = new Path(dir, fileName); | |||
| fileIO.overwriteFileUtf8(hintFile, String.valueOf(snapshotId)); | |||
| FileIOUtils.overwriteFileUtf8WithRetry(fileIO, hintFile, String.valueOf(snapshotId), 3); | |||
There was a problem hiding this comment.
Hard code here? Or make it configurable better？
JingsongLi
reviewed
Dec 13, 2024
| return; | ||
| } catch (IOException e) { | ||
| try { | ||
| Thread.sleep(RANDOM.nextInt(1000) + 500); |
There was a problem hiding this comment.
ThreadLocalRandom.current()
JingsongLi
reviewed
Dec 13, 2024
| Thread.sleep(RANDOM.nextInt(1000) + 500); | ||
| } catch (InterruptedException ex) { | ||
| // throw root cause | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Thread.currentThread().interrupt();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Maybe over-writer file will fail, so it's better to add some retries.
Tests
API and Format
Documentation