Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] update drop Database API and remove api in URL #4691

Merged
merged 8 commits into from
Dec 12, 2024
Merged

[Core] update drop Database API and remove api in URL #4691

merged 8 commits into from
Dec 12, 2024

Conversation

jerry-024
Copy link
Contributor

@jerry-024 jerry-024 commented Dec 12, 2024 •
edited
Loading

Purpose

  • update drop Database API:
    • follow HTTP API delete couldn't have the request
    • same as catalog API defines
  • remove api in URL: follow others: like iceberg and flink

Linked issue: #4540

Tests

  • RESTCatalogTest

API and Format

No

Documentation

No

@jerry-024 jerry-024 marked this pull request as draft December 12, 2024 04:28
@jerry-024 jerry-024 marked this pull request as draft December 12, 2024 04:28
@jerry-024 jerry-024 marked this pull request as ready for review December 12, 2024 07:21
JingsongLi
JingsongLi approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 96bcfda into apache:master Dec 12, 2024
12 checks passed
@jerry-024 jerry-024 deleted the rest-catalog branch December 12, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerry-024 @JingsongLi