[core] Introduce data-file.thin-mode in primary key table write #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
leaves12138
force-pushed
the
KeymmedKeyInWrite
branch
from
741f14f to
7f0442e
Compare
leaves12138
changed the title
leaves12138
changed the title
added 2 commits
December 10, 2024 14:31
leaves12138
force-pushed
the
KeymmedKeyInWrite
branch
from
6ea1031 to
b1aa915
Compare
JingsongLi
reviewed
Dec 10, 2024
leaves12138
changed the title
JingsongLi
changed the title
tsreaper
reviewed
Dec 10, 2024
paimon-core/src/main/java/org/apache/paimon/io/KeyValueDataFileWriter.java
Outdated
Show resolved
Hide resolved
added 4 commits
December 10, 2024 17:11
tsreaper
reviewed
Dec 10, 2024
paimon-core/src/main/java/org/apache/paimon/mergetree/MergeTreeWriter.java
Outdated
Show resolved
Hide resolved
added 4 commits
December 10, 2024 18:38
xuzifu666
reviewed
Dec 11, 2024
paimon-core/src/test/java/org/apache/paimon/table/PrimaryKeyFileStoreTableTest.java
Outdated
Show resolved
Hide resolved
wwj6591812
reviewed
Dec 12, 2024
paimon-core/src/main/java/org/apache/paimon/io/KeyValueThinDataFileWriterImpl.java
Outdated
Show resolved
Hide resolved
| return toRow(record.sequenceNumber(), record.valueKind(), record.value()); | ||
| } | ||
|
|
||
| public InternalRow toRow(long sequenceNumber, RowKind valueKind, InternalRow value) { |
There was a problem hiding this comment.
Suggest add a comment here.
record.key() is not write into row
There was a problem hiding this comment.
Already comment before class definition.
JingsongLi
reviewed
Dec 12, 2024
paimon-core/src/main/java/org/apache/paimon/io/KeyValueThinDataFileWriterImpl.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/utils/StatsCollectorFactories.java
Outdated
Show resolved
Hide resolved
added 3 commits
December 12, 2024 12:27
JingsongLi
approved these changes
Dec 12, 2024
tsreaper
reviewed
Dec 12, 2024
Comment on lines
57
to
58
| || (options.dataFileThinMode() | ||
| && keyNames.contains(SpecialFields.KEY_FIELD_PREFIX + field))) { |
There was a problem hiding this comment.
Add comments about why do we need this condition.
Comment on lines
195
to
197
| Options options = new Options(); | ||
| options.set(CoreOptions.DATA_FILE_THIN_MODE, false); | ||
|
|
There was a problem hiding this comment.
Default value of CoreOptions.DATA_FILE_THIN_MODE is false, why do we need this change? Even if the default value changes to true, will it break the test?
tsreaper
reviewed
Dec 13, 2024
| } else if (SpecialFields.isSystemField(field)) { | ||
| } else if (SpecialFields.isSystemField(field) | ||
| || | ||
| // If we config METADATA_STATS_MODE to true, we need to maintain the |
| @@ -192,6 +192,8 @@ public void testRewriteSuccess(boolean rewriteChangelog) throws Exception { | |||
|
|
|||
| private KeyValueFileWriterFactory createWriterFactory( | |||
| Path path, RowType keyType, RowType valueType) { | |||
| Options options = new Options(); | |||
There was a problem hiding this comment.
We don't need this change now.
| @@ -143,6 +143,7 @@ private void recreateMergeTree(long targetFileSize) { | |||
| options.set( | |||
| CoreOptions.NUM_SORTED_RUNS_STOP_TRIGGER, | |||
| options.get(CoreOptions.NUM_SORTED_RUNS_COMPACTION_TRIGGER) + 1); | |||
| options.set(CoreOptions.DATA_FILE_THIN_MODE, false); | |||
There was a problem hiding this comment.
Why do we need this change?
added 3 commits
December 13, 2024 11:44
tsreaper
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Writing primary key table, now, we generates spare column.
For example:
One table with column a,b,c,d,e,f,g primary-key: a,b
In which, _KEY_a and _KEY_b are totally equal to a, b.
Therefore, we introduce
data-file.thin-modehere:Notice that: If thin-mode is on, the files it write could not be read by former paimon sdk version. Linked issue: #4651