[iceberg] introduce procedure for migrating iceberg table to paimon #4664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # paimon-core/src/main/java/org/apache/paimon/iceberg/metadata/IcebergDataField.java
xuzifu666
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Good job! It is an important way for iceberg user migrate to paimon, left some comments @LsomeYeah
|
|
||
| import static org.apache.paimon.utils.ThreadPoolUtils.createCachedThreadPool; | ||
|
|
||
| /** migrate hive table to paimon table. */ |
There was a problem hiding this comment.
migrate iceberg table to paimon table？
|
|
||
| import org.apache.flink.table.annotation.ArgumentHint; | ||
| import org.apache.flink.table.annotation.DataTypeHint; | ||
| import org.apache.flink.table.annotation.ProcedureHint; | ||
| import org.apache.flink.table.procedure.ProcedureContext; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** Migrate procedure to migrate hive table to paimon table. */ | ||
| public class MigrateTableProcedure extends ProcedureBase { |
There was a problem hiding this comment.
Will add it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
In pr #4639, we had introduced the feature to migrating iceberg table to paimon.
This pr added corresponding procedures and IT cases.
Tests
org.apache.paimon.hive.procedure.MigrateIcebergTableProcedureITCase
org.apache.paimon.procedure.MigrateIcebergTableProcedure23ITCase
org.apache.paimon.procedure.MigrateIcebergTableProcedure31ITCase
API and Format
Documentation