[core] Unify the order of procedure loading properties #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Dec 8, 2024
| throws Catalog.TableNotExistException { | ||
| FileStoreTable fileStoreTable = (FileStoreTable) table(tableId); | ||
| Map<String, String> dynamicOptions = new HashMap<>(); |
There was a problem hiding this comment.
These code is same as three ExpirePartitionsProcedure
There was a problem hiding this comment.
Thks, added a unified util method.
askwang
changed the title
Zouxxyy
reviewed
Dec 18, 2024
|
|
||
| PartitionExpire partitionExpire = | ||
| new PartitionExpire( | ||
| TimeUtils.parseDuration(expirationTime), | ||
| fileStore.options().partitionExpireTime(), |
There was a problem hiding this comment.
use newPartitionExpire in FileStore
| map.put(CoreOptions.PARTITION_TIMESTAMP_PATTERN.key(), timestampPattern); | ||
|
|
||
| // check expiration time not null | ||
| Preconditions.checkNotNull( |
There was a problem hiding this comment.
this maybe can be checked in FileStore internal
| CoreOptions tableOptions = ((FileStoreTable) table).store().options(); | ||
| ExpireConfig.Builder builder = | ||
| ProcedureUtils.fillInSnapshotOptions( | ||
| tableOptions, retainMax, retainMin, olderThanStr, maxDeletes); | ||
| int deleted = expireSnapshots.config(builder.build()).expire(); |
There was a problem hiding this comment.
table.newExpireSnapshots() should include the dynamicOptions instead of inserting it through the builder, if not maybe we should fix it
There was a problem hiding this comment.
Yes, you are right. We should not update properties using the builder after table.newExpireSnapshots() which should included in dynamicOptions.
I will remove the builder way in another pr, WDYT？ @Zouxxyy
askwang
force-pushed
the
load-table-prop-first
branch
from
75a3ae3 to
a6aa2be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If the table property have related properties, we do not need to configure them separately in procedure, unify them for expire_partitions and expire_snapshots.
Tests
API and Format
Documentation