[core] Use min/max to fast skip the bsi index comparison #4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tan-JiaLiang
force-pushed
the
feat/bsi_fast_skip
branch
from
021a3f2 to
2b9f89c
Compare
JingsongLi
reviewed
Dec 4, 2024
| @@ -220,6 +309,7 @@ public boolean isNotEmpty() { | |||
| public void serialize(DataOutput out) throws IOException { | |||
| out.writeByte(VERSION_1); | |||
| out.writeLong(min); | |||
| out.writeLong(max); | |||
There was a problem hiding this comment.
Can you add detailed format to the page: https://paimon.apache.org/docs/master/concepts/spec/fileindex/
You can add an explanation for bsi serialized.
JingsongLi
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Firstly, When users turn off to collect the column stats, bsi compare would return a wrong result. Because the predicate can not out of the bsi min/max range in oneil compare.
Secondly, using min/max compare can fast return. e.g. in the GT case, if the predicate is less than the min value, we just need to return the existence bitmap.
At last, because of the v1.0 in paimon is not yet released, I didn't do the compatibility work about the bsi index.
Tests
org.apache.paimon.utils.BitSliceIndexRoaringBitmapTest
API and Format
Documentation