[flink] Avoid deprecated usage on TableSchema, DataType and DescriptorProperties #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
JingsongLi
reviewed
Dec 2, 2024
@JingsongLi Map<String, String> expected = new HashMap<>();
String watermarkPrefix = compoundKey(SCHEMA, WATERMARK, 0);
expected.put(compoundKey(watermarkPrefix, WATERMARK_ROWTIME), "test_time");
expected.put(
compoundKey(watermarkPrefix, WATERMARK_STRATEGY_EXPR),
"`test_time` - INTERVAL '0.001' SECOND");
expected.put(compoundKey(watermarkPrefix, WATERMARK_STRATEGY_DATA_TYPE), "TIMESTAMP(3)");This code stands for the serialization result since the older versions of Paimon. This PR does not change this part of code, which means the compatibility should be guaranteed. |
JingsongLi
reviewed
Dec 2, 2024
| return builder.build(); | ||
| } | ||
|
|
||
| @Override | ||
| public CatalogBaseTable copy() { | ||
| return new DataCatalogTable( | ||
| table, | ||
| getSchema().copy(), | ||
| Schema.newBuilder().fromSchema(schema).build(), |
There was a problem hiding this comment.
Why need to copy it? I see there is no copy in DefaultCatalogTable.
There was a problem hiding this comment.
The copy was added because the copy had been made in the existing implementation. But I agree with it that the copy is unnecessary. I'll remove it.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #4442
This PR removes deprecated usages about Flink Table API, mainly including TableSchema and DescriptorProperties.
Tests
Existing test cases are used to verify this change.
API and Format
This change does not affect API or storage format.
Documentation
This change does not affect introduce a new feature.