[spark] adjust paimon spark structure #4573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannByron
force-pushed
the
spark-structure
branch
3 times, most recently
from
b6d0f2b to
cfc8fbb
Compare
YannByron
changed the title
YannByron
force-pushed
the
spark-structure
branch
from
90749db to
0ab2a77
Compare
YannByron
changed the title
|
@Zouxxyy @JingsongLi please take a look. |
JingsongLi
reviewed
Nov 25, 2024
| private def loadSparkShim(): SparkShim = { | ||
| val shims = ServiceLoader.load(classOf[SparkShim]).asScala | ||
| if (shims.size != 1) { | ||
| throw new IllegalStateException("No available spark shim here.") |
There was a problem hiding this comment.
Handle multiple versions in the classloader.
Zouxxyy
reviewed
Nov 26, 2024
| /** Load a [[SparkShim]]'s implementation. */ | ||
| object SparkShimLoader { | ||
|
|
||
| private var sparkShim: SparkShim = _ |
Zouxxyy
reviewed
Nov 26, 2024
| import org.apache.spark.sql.catalyst.InternalRow | ||
| import org.apache.spark.sql.paimon.shims.SparkShimLoader | ||
|
|
||
| abstract class SparkInternalRow extends InternalRow { |
There was a problem hiding this comment.
Why we need this, the current inheritance structure is three layers.
Spark3InternalRow extends AbstractSparkInternalRow entends SparkInternalRow
There was a problem hiding this comment.
For this kind of interface, I prefer to keep the definition and implementation separate.
|
|
||
| abstract class InternalRow extends SparkInternalRow {} | ||
| override def createSparkInternalRow(rowType: RowType): SparkInternalRow = { | ||
| new Spark3InternalRow(rowType) |
There was a problem hiding this comment.
Maybe we can use a unified style, such as unifying PaimonSpark3SqlExtensionsParser Spark3InternalRow,
or PaimonSparkSqlExtensionsParser SparkInternalRow.
There was a problem hiding this comment.
Right，I choose the first style.
Zouxxyy
approved these changes
Nov 26, 2024
YannByron
force-pushed
the
spark-structure
branch
from
f414e22 to
14b1371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To modify the spark structure as below (It is similar to Apache Gluten https://github.com/apache/incubator-gluten):
spark-commonmodule to the bottom layer, and make thespark3-commonandspark4-commonmodules depend on it;spark-utmodule;spark-3.5orspark-4.0) can directly depend on thesparkx-commonmodule with the corresponding major version (eg:spark3.5->spark3-common,spark4.0->spark4-common);spark-utandsparkx-commonmodules;SparkShiminterface and the SPI mechanism to solve the incompatibility problem, instead of overwriting the classes with the same class name;Linked issue: close #xxx
Tests
API and Format
Documentation