[Hive] Fix Hive DDL and paimon schema mismatched bug #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -233,9 +233,10 @@ private static void checkFieldsMatched( | |||
| } | |||
| } | |||
|
|
|||
| if (schemaFieldNames.size() != hiveFieldNames.size()) { | |||
| // It is OK that hive is a subset of paimon | |||
| if (schemaFieldNames.size() < hiveFieldNames.size()) { | |||
There was a problem hiding this comment.
Checking by List#size() is not precise, Set#containsAll() maybe a better choice. :)
There was a problem hiding this comment.
The following code will be checked one by one, I think it is OK
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: issue-4556
HiveCatalog add column is divided into two stages: first modify the paimon schema, then modify HMS. There will be a time difference between the two stages. If there is a task read (based on hivecatalog) during this time, the paimon schema and hive schema check will fail in the getDataFieldsJsonStr link.
Solution: Actually, you only need to ensure that the Hive DDL is a subset of the paimon schema.
Tests
org.apache.paimon.hive.HiveTableSchemaTest#testSupersetColumnNameAndType
org.apache.paimon.hive.HiveTableSchemaTest#testSubsetColumnNameAndType
API and Format
org.apache.paimon.hive.HiveSchema#checkPartitionMatched
Documentation
only need to ensure that the Hive DDL is a subset of the paimon schema.