Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove FileStoreScan.withManifestList and fix unstable test #4552

Merged
merged 3 commits into from
Nov 20, 2024
Merged

[core] Remove FileStoreScan.withManifestList and fix unstable test #4552

merged 3 commits into from
Nov 20, 2024

Conversation

JingsongLi
Copy link
Contributor

Purpose

  • FileStoreScan.withManifestList is only used by test code, we should remove it.
  • Fix unstable test ExpireSnapshotsTest.testChangelogOutLivedSnapshot

Tests

API and Format

Documentation

leaves12138
leaves12138 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@leaves12138 leaves12138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leaves12138 leaves12138 merged commit da4d64b into apache:master Nov 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaves12138 leaves12138 leaves12138 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JingsongLi @leaves12138