Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flink] change env.fromData to fromElements for compatibility with flink 1.18 and lower versions #4541

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

LsomeYeah
Copy link
Contributor

Purpose

Linked issue: close #xxx

In FlinkOrphanFilesClean#doOrphanClean, env.fromData is used for collecting information. While env.fromData was introduced in Flink 1.19, so it'll throw NoSuchMethodError when used in Flink 1.18- version. This pr changed env.fromData to env.fromElements to be compatible with lower flink versions.

Tests

API and Format

Documentation

@JingsongLi
Copy link
Contributor

Please add tests.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit ebef050 into apache:master Nov 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants