Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[orc] Add type id to orc files #4523

Merged
merged 3 commits into from
Nov 19, 2024
Merged

[orc] Add type id to orc files #4523

merged 3 commits into from
Nov 19, 2024

Conversation

yuzelin
Copy link
Contributor

@yuzelin yuzelin commented Nov 13, 2024

Purpose

Same to #4362

Tests

API and Format

Documentation

@yuzelin yuzelin changed the title WIP [parquet] Add type id to orc files WIP [orc] Add type id to orc files Nov 14, 2024
@yuzelin yuzelin changed the title WIP [orc] Add type id to orc files [orc] Add type id to orc files Nov 15, 2024
@@ -32,23 +34,41 @@
/** Util for orc types. */
public class OrcSplitReaderUtil {

public static TypeDescription toOrcType(DataType type) {
public static final String PAIMON_ORC_FIELD_ID_KEY = "paimon.field.id";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paimon.id?

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also modify convert orc type to paimon type, and check field id?

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 06fbb5e into apache:master Nov 19, 2024
12 checks passed
@yuzelin yuzelin deleted the orc_id branch December 4, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants