-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[orc] Add type id to orc files #4523
Conversation
@@ -32,23 +34,41 @@ | |||
/** Util for orc types. */ | |||
public class OrcSplitReaderUtil { | |||
|
|||
public static TypeDescription toOrcType(DataType type) { | |||
public static final String PAIMON_ORC_FIELD_ID_KEY = "paimon.field.id"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paimon.id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also modify convert orc type to paimon type, and check field id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose
Same to #4362
Tests
API and Format
Documentation