[core] Support delete stats in result of scan plan. #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
force-pushed
the
support_delete_stats_in_result_of_plan_1112
branch
from
a0d5f66 to
1c5dbff
Compare
wwj6591812
changed the title
wwj6591812
force-pushed
the
support_delete_stats_in_result_of_plan_1112
branch
2 times, most recently
from
3bc538e to
4e6a4f0
Compare
wwj6591812
changed the title
wwj6591812
changed the title
|
@JingsongLi Hi，Please CC, Thx. |
JingsongLi
requested changes
Nov 18, 2024
| @@ -409,6 +409,27 @@ public DataFileMeta rename(String newFileName) { | |||
| valueStatsCols); | |||
| } | |||
|
|
|||
| public DataFileMeta withoutStats() { | |||
| rowCount, | ||
| minKey, | ||
| maxKey, | ||
| EMPTY_STATS, |
There was a problem hiding this comment.
It is better to keep key stats?
| deleteRowCount, | ||
| embeddedIndex, | ||
| fileSource, | ||
| valueStatsCols); |
| @@ -121,6 +121,10 @@ public Identifier identifier() { | |||
| file.embeddedIndex()); | |||
| } | |||
|
|
|||
| public ManifestEntry withoutStats() { | |||
| @@ -215,6 +217,12 @@ public FileStoreScan withMetrics(ScanMetrics metrics) { | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| public FileStoreScan withoutStatsInPlan() { | |||
| @@ -81,6 +81,8 @@ public interface FileStoreScan { | |||
|
|
|||
| FileStoreScan withMetrics(ScanMetrics metrics); | |||
|
|
|||
| FileStoreScan withoutStatsInPlan(); | |||
| @@ -102,6 +102,12 @@ public AbstractDataTableScan withMetricsRegistry(MetricRegistry metricsRegistry) | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| public AbstractDataTableScan withoutStatsInPlan() { | |||
| @@ -55,4 +55,9 @@ default InnerTableScan withMetricsRegistry(MetricRegistry metricRegistry) { | |||
| // do nothing, should implement this if need | |||
| return this; | |||
| } | |||
|
|
|||
| default InnerTableScan withoutStatsInPlan() { | |||
| @@ -150,6 +150,9 @@ default ReadBuilder withProjection(int[][] projection) { | |||
| */ | |||
| ReadBuilder withShard(int indexOfThisSubtask, int numberOfParallelSubtasks); | |||
|
|
|||
| /** Delete stats in scan plan result. */ | |||
| ReadBuilder withoutStatsInPlan(); | |||
wwj6591812
force-pushed
the
support_delete_stats_in_result_of_plan_1112
branch
from
4e6a4f0 to
1783216
Compare
wwj6591812
force-pushed
the
support_delete_stats_in_result_of_plan_1112
branch
from
1783216 to
2f53687
Compare
|
@JingsongLi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In my company's production environment, when use Flink session cluster for OLAP scan Paimon, we found the JobManager's memory is always heavy.
So, we will optimize this by two ways:
(1) Delete stats in DataSplit.
(2) When dataSkipping, cut unused stats in ManifestEntry.
This pr is for (1)
Linked issue: close #xxx
Tests
API and Format
Documentation