Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Update doc style #4465

Merged
merged 4 commits into from
Nov 7, 2024
Merged

[doc] Update doc style #4465

merged 4 commits into from
Nov 7, 2024

Conversation

Edward-Gavin
Copy link
Contributor

Purpose

Linked issue: close #4449

Inspired by issue 4449 and CloneActionITCase, I update clone-tables.md style. Does anyone have any better suggestions?

Tests

no

API and Format

no

Documentation

Update docs/content/flink/clone-tables.md and docs/content/flink/expire-partition.md.

@JingsongLi
Copy link
Contributor

Hi @Edward-Gavin , thanks for the contribution.

But can you gather all minor doc or comment PRs? Creating too many fragmented PRs, all of which involve minor modifications to the document, can cost the reviewer's energy.

@Edward-Gavin
Copy link
Contributor Author

Hi @Edward-Gavin , thanks for the contribution.

But can you gather all minor doc or comment PRs? Creating too many fragmented PRs, all of which involve minor modifications to the document, can cost the reviewer's energy.

Thanks for your time and suggestion, I will commit all modifications that I find in this pr.

@wwj6591812
Copy link
Contributor

+1

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit da3e795 into apache:master Nov 7, 2024
2 checks passed
@Edward-Gavin Edward-Gavin deleted the doc_bug branch November 7, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants