-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spark] Add rollback ddl syntax #4462
Conversation
Why do we need a new |
} | ||
case t => | ||
throw new UnsupportedOperationException( | ||
s"Can not delete tag for non-paimon FileStoreTable: $t") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can not delete tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mistake, updated, ths
SQL syntax support will be provided later, it is the same as procedure call. |
Why do we use |
I think tag/snapshot are also part of the table meta info, maybe we can use alter table to modify it. |
@@ -104,6 +105,12 @@ timeUnit | |||
| MINUTES | |||
; | |||
|
|||
kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timeTravelKind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed.
I agree with your idea. I have checked and currently no other lake formats have implemented custom syntax here. We can consider temporarily stopping and using CALL is not a bad idea. @askwang What do you think? |
In my mind, rollback should actually generate a new snapshot containing the changes, from this perspective, alter table should not be used. (although the current implementation directly deletes the existing snapshots). Besides in spark doc description: ALTER TABLE statement changes the schema or properties of a table. |
ok |
Purpose
Add rollback to snapshot/tag/timestamp ddl syntax.
Tests
API and Format
Documentation