Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Introduce refreshPartitions interface to CachingCatalog #4455

Merged
merged 3 commits into from
Nov 5, 2024
Merged

[core] Introduce refreshPartitions interface to CachingCatalog #4455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d95941
[core] Introduce refreshPartitions interface to CachingCatalog
mxdzs0612 Nov 5, 2024
f14ed2b
fix comments
mxdzs0612 Nov 5, 2024
ad71a0a
fix comments2
mxdzs0612 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions paimon-core/src/main/java/org/apache/paimon/catalog/CachingCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,13 @@ public List<PartitionEntry> listPartitions(Identifier identifier)
return result;
}

public void refreshPartitions(Identifier identifier) throws TableNotExistException {
if (partitionCache != null) {
List<PartitionEntry> result = wrapped.listPartitions(identifier);
partitionCache.put(identifier, result);
}
}

@Override
public void dropPartition(Identifier identifier, Map<String, String> partitions)
throws TableNotExistException, PartitionNotExistException {
Expand All @@ -289,6 +296,9 @@ public void onRemoval(Identifier identifier, Table table, @NonNull RemovalCause
public void invalidateTable(Identifier identifier) {
tableCache.invalidate(identifier);
tryInvalidateSysTables(identifier);
if (partitionCache != null) {
partitionCache.invalidate(identifier);
}
}

private void tryInvalidateSysTables(Identifier identifier) {
Expand Down
3 changes: 3 additions & 0 deletions paimon-core/src/test/java/org/apache/paimon/catalog/CachingCatalogTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ public void testPartitionCache() throws Exception {
catalog.createTable(tableIdent, schema, false);
List<PartitionEntry> partitionEntryList = catalog.listPartitions(tableIdent);
assertThat(catalog.partitionCache().asMap()).containsKey(tableIdent);
catalog.invalidateTable(tableIdent);
catalog.refreshPartitions(tableIdent);
assertThat(catalog.partitionCache().asMap()).containsKey(tableIdent);
List<PartitionEntry> partitionEntryListFromCache =
catalog.partitionCache().getIfPresent(tableIdent);
assertThat(partitionEntryListFromCache).isNotNull();
Expand Down
Loading