Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdc] Fix ambiguous naming in CdcRecord #4450

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

zhuyaogai
Copy link
Contributor

Purpose

Linked issue: close #xxx

Currently, the field named fields in CdcRecord look like schema info, but actually represent data info, which is ambiguous. And there is also some ambiguity with RichCdcRecord field naming. So I rename the the field named fields in CdcRecord to data.

Tests

Existing

API and Format

No

Documentation

No

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 7c4fd96 into apache:master Nov 5, 2024
11 of 12 checks passed
hang8929201 pushed a commit to hang8929201/paimon that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants