[core] throw exception if table is recreated when it still being read #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsreaper
reviewed
Nov 5, 2024
| "The next expected snapshot is too big! Most possible cause might be the table had been recreated." | ||
| + "The next snapshot id is %d, while the latest snapshot id is %s", | ||
| nextSnapshotId, | ||
| latestSnapshotId == null ? "null" : latestSnapshotId)); |
There was a problem hiding this comment.
Suggested change
| latestSnapshotId == null ? "null" : latestSnapshotId)); | |
| latestSnapshotId)); |
Comment on lines
383
to
384
| // wait the read job to read the current table | ||
| Thread.sleep(10000); |
There was a problem hiding this comment.
Assert that all snapshots are read by checking the result of SELECT. Don't sleep for this long!
Comment on lines
349
to
353
| "CREATE TABLE t ( pt INT, k INT, v INT, PRIMARY KEY (pt, k) NOT ENFORCED ) " | ||
| + "PARTITIONED BY (pt) " | ||
| + "WITH (" | ||
| + " 'bucket' = '2'\n" | ||
| + ")"); |
There was a problem hiding this comment.
Set continuous.discovery-interval to a smaller value (for example 1s or 500ms) so this test can run faster. No need to wait for 10 seconds.
tsreaper
reviewed
Nov 6, 2024
Comment on lines
410
to
417
| assertThatCode( | ||
| () -> { | ||
| while (true) { | ||
| if (it.hasNext()) { | ||
| it.next(); | ||
| } | ||
| } | ||
| }) |
There was a problem hiding this comment.
Suggested change
| assertThatCode( | |
| () -> { | |
| while (true) { | |
| if (it.hasNext()) { | |
| it.next(); | |
| } | |
| } | |
| }) | |
| assertThatCode(() -> it.next()) |
tsreaper
approved these changes
Nov 7, 2024
hang8929201
pushed a commit
to hang8929201/paimon
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
A table which is read in streaming read, will not throw exception even if the table is recreated currently. For example, the expected snapshot id is 10001, but the latest snapshot of the recreated table might be null or much less than 10001.
This is because when try to get the next snapshot, if the next snapshot is not exists in filesystem and its id is greater than earliest snapshot id, it will be treat as the next snapshot is still in generating progress.
This feature adds a check in
NextSnapshotFetcher#getNextSnapshot. If next expected snapshot id is greater than the latest snapshot id plus one, it will throw an exception.Tests
PrimaryKeyFileStoreTableITCase#testRecreateTableWithExceptionAPI and Format
Documentation