Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add avg/max/total compaction io size metric #4392

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Aitozi
Copy link
Contributor

@Aitozi Aitozi commented Oct 28, 2024

Purpose

Some bucket level IO size metrics are removed in https://github.com/apache/paimon/pull/2930/files

This PR add the avg/max/total compaction input & output io size metrics back.

Tests

API and Format

Documentation

@Aitozi Aitozi force-pushed the compaction-metric branch from aae5149 to 4990fa7 Compare October 28, 2024 13:14
@wwj6591812
Copy link
Contributor

+1

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update documentation and explain the meaning for new metrics?

@JingsongLi
Copy link
Contributor

@Aitozi You can take a look to #4391 too.

@Aitozi
Copy link
Contributor Author

Aitozi commented Oct 29, 2024

Can you update documentation and explain the meaning for new metrics?

Updated.

@Aitozi Aitozi requested a review from JingsongLi October 29, 2024 11:00
@Aitozi Aitozi force-pushed the compaction-metric branch from 483ddad to e814e4c Compare October 30, 2024 03:24
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 0797e81 into apache:master Oct 30, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants