[flink] PartitionMarkDone enables the use of various partition trigge… #4386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WDYT? @JingsongLi |
|
Hi @Aitozi , can you explain this pr from API level? Or you are modifying current behavior? |
|
@JingsongLi The behavior is not change. In this PR, I extract the In |
JingsongLi
reviewed
Oct 29, 2024
|
|
||
| public PartitionMarkDoneTrigger( | ||
| State state, | ||
| PartitionTimeExtractor timeExtractor, | ||
| @Nullable Duration timeInterval, | ||
| @Nullable Duration idleTime, | ||
| boolean markDoneWhenEndInput) | ||
| boolean markDoneWhenEndInput, |
There was a problem hiding this comment.
Can you keep PartitionMarkDone as it is?
There was a problem hiding this comment.
I reset the commit, and updated in #4398
| import java.util.List; | ||
|
|
||
| /** Partition collector. */ | ||
| public class PartitionCollector implements Closeable { |
| import java.util.List; | ||
|
|
||
| /** The partition trigger. */ | ||
| public interface PartitionTrigger extends Closeable { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r strategies.
Purpose
Linked issue: close #xxx
In our company, we have encountered an issue with the HMS partition statistic being incorrect. This is because during the writing process, we only update the metastore partition when it is first written to.
Therefore, we would like to implement the PartitionMarkDone strategy to update the statistics in HMS after a short idle period for each partition.
We need a separate configuration for PartitionMarkDone due to differing requirements:
To achieve this, we plan on extending
PartitionMarkDonefunctionality to support different trigger strategies for partitions. Following this extension, we will be able to introduce custom triggers such asPartitionHmsReporterTrigger.Tests
API and Format
Documentation