Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdc] Add flink execution mode check for cdc table sync action. #4378

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

LinMingQiang
Copy link
Contributor

@LinMingQiang LinMingQiang commented Oct 25, 2024

Purpose

Linked issue: close #xxx

Flink-cdc do not support batch mode, including flink cdc snapshot scan mode . Although it is a bounded source.

https://issues.apache.org/jira/browse/FLINK-36280

apache/flink-cdc#2901

if use set RuntimeExecutionMode = Batch. job will be never finish and never fail.

image

so , we need to check the flink execution mode.

Tests

API and Format

Documentation

@LinMingQiang
Copy link
Contributor Author

If this change is acceptable, I will complete the other actions / mongodb/Postgres.

@wwj6591812
Copy link
Contributor

Do we need to handle RuntimeExecutionMode.AUTOMATIC?

@LinMingQiang
Copy link
Contributor Author

Do we need to handle RuntimeExecutionMode.AUTOMATIC?

yes need too, may be we can make STREAMING mode as default and ignore the user's settings.

@LinMingQiang
Copy link
Contributor Author

@yuzelin Help me check this pr? tks.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit a0727bd into apache:master Oct 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants