Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spark] support to mark done for spark writer #4363

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

Aitozi
Copy link
Contributor

@Aitozi Aitozi commented Oct 22, 2024

Purpose

Linked issue: close #4361 4361

Tests

API and Format

Documentation

Seq.empty
}

private def markDone(commitMessages: Seq[CommitMessage]): Unit = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markPartitionDoneIfNeeded

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

val partitions = commitMessages
.map(c => c.partition())
.map(p => PartitionPathUtils.generatePartitionPath(partitionComputer.generatePartValues(p)))
for (elem <- partitions) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elem -> partition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit a0f3ea8 into apache:master Oct 23, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Decouple the PartitionMarkDone from Flink to enable marking as done for Spark batch processing.
3 participants