[core] Fix partition column generate wrong partition spec #4349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Paimon uses
.toString
to generate partition value, which is not accurate for some data types. like date/binary. Say, Spark engine would use aCast
to convert a partition object to string value. So this pr changes to use cast to generate partition value.Add a new config
partition.legacy-name
to support switch to use previoustoString
behavior, and by default use the legacy behavior(.toString).An example that using binary type partition column would cause failure.
Tests
add test
API and Format
no
Documentation
added docs