[spark] Support spark DropPartition with sync metastore #4339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Oct 16, 2024
| try { | ||
| commit.dropPartitions(partitions.toSeq.asJava, BatchWriteBuilder.COMMIT_IDENTIFIER) | ||
| // syn to metastore with delete partitions |
| metastoreClient = clientFactory.create() | ||
| toPaimonPartitions(rows).foreach(metastoreClient.deletePartition) | ||
| } | ||
|
|
There was a problem hiding this comment.
delete excess blank line
|
@wwj6591812 Thanks, had addressed |
JingsongLi
reviewed
Oct 17, 2024
| try { | ||
| commit.dropPartitions(partitions.toSeq.asJava, BatchWriteBuilder.COMMIT_IDENTIFIER) | ||
| // sync to metastore with delete partitions | ||
| if (clientFactory != null) { |
There was a problem hiding this comment.
should check metastore.partitioned-table. (Please add case for disabled metastore.partitioned-table table too)
There was a problem hiding this comment.
Yes，had added a check for metastore.partitioned-table and case. Thanks @JingsongLi
JingsongLi
reviewed
Oct 17, 2024
| try { | ||
| commit.dropPartitions(partitions.toSeq.asJava, BatchWriteBuilder.COMMIT_IDENTIFIER) | ||
| // sync to metastore with delete partitions | ||
| if (clientFactory != null) { |
There was a problem hiding this comment.
Also for createPartitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Currently after paimon spark drop partition not sync to metastore like flink(#3411), this pr is aim to support it.
Tests
API and Format
Documentation