Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Improve TruncateSimpleColStatsCollector performance #4338

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[core] Improve TruncateSimpleColStatsCollector performance #4338

merged 1 commit into from
Oct 16, 2024

Conversation

ulysses-you
Copy link
Contributor

Purpose

This pr improves TruncateSimpleColStatsCollector performance:

  1. avoid doing tuncate if previous row failed to truncate max
  2. avoid unnecessary copy if we succeeded to tuncate max
  3. avoid truncate max twice

Tests

the test has been convered by SimpleColStatsCollectorTest

API and Format

no

Documentation

@ulysses-you
Copy link
Contributor Author

cc @JingsongLi thank you

JingsongLi
JingsongLi approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 668e673 into apache:master Oct 16, 2024
12 checks passed
@ulysses-you ulysses-you deleted the truncate branch October 16, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulysses-you @JingsongLi