[core] Enable file index for DV table #4310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Oct 13, 2024
| @@ -121,10 +134,33 @@ protected boolean filterByStats(ManifestEntry entry) { | |||
| } | |||
|
|
|||
| return filter.test( | |||
There was a problem hiding this comment.
Add "long schemaId = entry.file().schemaId();" in KeyValueFileStoreScan#filterByStats, and then use schemaId in KeyValueFileStoreScan#filterByStats and KeyValueFileStoreScan#testFileIndex.
paimon-core/src/main/java/org/apache/paimon/operation/KeyValueFileStoreScan.java
Outdated
Show resolved
Hide resolved
| new FileIndexPredicate(embeddedIndexBytes, dataRowType)) { | ||
| return predicate.testPredicate(dataPredicate); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Exception happens while checking predicate.", e); |
There was a problem hiding this comment.
Exception happens while checking fileIndex predicate.
|
|
||
| private boolean testFileIndex(@Nullable byte[] embeddedIndexBytes, ManifestEntry entry) { | ||
| if (embeddedIndexBytes == null) { | ||
| return true; |
There was a problem hiding this comment.
If fileIndex does not exist in embeddedIndex but in a separate file, what logic of filter by FileIndex in pk table with DV?
| @@ -238,7 +238,8 @@ private KeyValueFileStoreScan newScan(boolean forWrite) { | |||
| options.scanManifestParallelism(), | |||
| options.deletionVectorsEnabled(), | |||
| options.mergeEngine(), | |||
| options.changelogProducer()); | |||
| options.changelogProducer(), | |||
| options.fileIndexReadEnabled() && options.deletionVectorsEnabled()); | |||
There was a problem hiding this comment.
Add "File index support Append Only tables and pk table with DV" in fileIndex doc
leaves12138
force-pushed
the
File_Index_For_DV
branch
from
ee6f76f to
5463266
Compare
leaves12138
force-pushed
the
File_Index_For_DV
branch
from
5463266 to
2e62702
Compare
hang8929201
pushed a commit
to hang8929201/paimon
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
File index is only support Append Only tables yet. But it is able to support primary-key table like Deletion Vector Table.
This pull request, enable
File Indexin DV table.Tests
API and Format
Documentation