Fix InsertOnly behavior for CDC and deduplication scenarios #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Oct 9, 2024
...flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/StoreSinkWriteImpl.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
record-attributes-processor-fix
branch
from
4540a78 to
89f4077
Compare
|
Thanks for the comments @wwj6591812 . I have updated the PR according to the comments. |
yunfengzhou-hub
force-pushed
the
record-attributes-processor-fix
branch
from
89f4077 to
3cbd407
Compare
|
+1 |
JingsongLi
reviewed
Oct 10, 2024
| @@ -65,6 +65,8 @@ public class StoreSinkWriteImpl implements StoreSinkWrite { | |||
|
|
|||
| @Nullable private final MetricGroup metricGroup; | |||
|
|
|||
| @Nullable private Boolean lastInsertOnly; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes InsertOnly related behavior in CDC and deduplication scenarios.
Related PR: #3791
API and Format
This change does not affect API or storage format.
Documentation
This change does not introduce changes that require a document.