[core] Manifest and Statistic support query by tag name #4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzifu666
changed the title
wwj6591812
reviewed
Oct 9, 2024
| @@ -170,8 +171,15 @@ public Identifier identifier() { | |||
| public Optional<Statistics> statistics() { | |||
| Snapshot latestSnapshot; | |||
| Long snapshotId = coreOptions().scanSnapshotId(); | |||
| String tagName = coreOptions().scanTagName(); | |||
|
|
|||
There was a problem hiding this comment.
Here add a check, if both snapshotId and tagName are not null, then there is ambiguity here.
There was a problem hiding this comment.
Not need worry about both set snapshot-id and tag-name，schema check would guard for it， user can only set one of snapshot-id and tag-name. @wwj6591812
| @@ -211,7 +213,11 @@ private static List<ManifestFileMeta> allManifests(FileStoreTable dataTable) { | |||
| } | |||
| snapshot = snapshotManager.snapshot(snapshotId); | |||
| } else if (snapshotId == null) { | |||
There was a problem hiding this comment.
here, Condition 'snapshotId == null' is always 'true'
| @@ -198,6 +199,7 @@ private static List<ManifestFileMeta> allManifests(FileStoreTable dataTable) { | |||
| CoreOptions coreOptions = CoreOptions.fromMap(dataTable.options()); | |||
| SnapshotManager snapshotManager = dataTable.snapshotManager(); | |||
| Long snapshotId = coreOptions.scanSnapshotId(); | |||
| String tagName = coreOptions.scanTagName(); | |||
There was a problem hiding this comment.
Here add a check, if both snapshotId and tagName are not null, then there is ambiguity here.
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Follow up #1667 and #4251
which can only support query by snapshot id, this pr is aimed to support tag name query.
Tests
API and Format
Documentation