Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flink] Emit event time lag should not increase when no new records are read #4281

Merged
merged 1 commit into from
Oct 3, 2024
Merged

[flink] Emit event time lag should not increase when no new records are read #4281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions ...imon-flink-common/src/main/java/org/apache/paimon/flink/source/operator/ReadOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ public class ReadOperator extends AbstractStreamOperator<RowData>
private transient IOManager ioManager;

private transient FileStoreSourceReaderMetrics sourceReaderMetrics;
// we create our own gauge for currentEmitEventTimeLag, because this operator is not a FLIP-27
// source and Flink can't automatically calculate this metric
private transient long emitEventTimeLag = FileStoreSourceReaderMetrics.UNDEFINED;
private transient Counter numRecordsIn;

public ReadOperator(ReadBuilder readBuilder) {
Expand All @@ -65,19 +68,7 @@ public void open() throws Exception {
super.open();

this.sourceReaderMetrics = new FileStoreSourceReaderMetrics(getMetricGroup());
// we create our own gauge for currentEmitEventTimeLag, because this operator is not a
// FLIP-27 source and Flink can't automatically calculate this metric
getMetricGroup()
.gauge(
MetricNames.CURRENT_EMIT_EVENT_TIME_LAG,
() -> {
long eventTime = sourceReaderMetrics.getLatestFileCreationTime();
if (eventTime == FileStoreSourceReaderMetrics.UNDEFINED) {
return FileStoreSourceReaderMetrics.UNDEFINED;
} else {
return System.currentTimeMillis() - eventTime;
}
});
getMetricGroup().gauge(MetricNames.CURRENT_EMIT_EVENT_TIME_LAG, () -> emitEventTimeLag);
this.numRecordsIn =
InternalSourceReaderMetricGroup.wrap(getMetricGroup())
.getIOMetricGroup()
Expand Down Expand Up @@ -108,6 +99,8 @@ public void processElement(StreamRecord<Split> record) throws Exception {
try (CloseableIterator<InternalRow> iterator =
read.createReader(split).toCloseableIterator()) {
while (iterator.hasNext()) {
emitEventTimeLag = System.currentTimeMillis() - eventTime;

// each Split is already counted as one input record,
// so we don't need to count the first record
if (firstRecord) {
Expand Down
12 changes: 11 additions & 1 deletion ...link-common/src/test/java/org/apache/paimon/flink/source/operator/OperatorSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ public void testReadOperatorMetricsRegisterAndUpdate() throws Exception {
readerOperatorMetricGroup, "currentEmitEventTimeLag")
.getValue())
.isEqualTo(-1L);

harness.processElement(new StreamRecord<>(splits.get(0)));
assertThat(
(Long)
Expand All @@ -211,13 +212,22 @@ public void testReadOperatorMetricsRegisterAndUpdate() throws Exception {
"currentFetchEventTimeLag")
.getValue())
.isGreaterThan(0);
long emitEventTimeLag =
(Long)
TestingMetricUtils.getGauge(
readerOperatorMetricGroup, "currentEmitEventTimeLag")
.getValue();
assertThat(emitEventTimeLag).isGreaterThan(0);

// wait for a while and read metrics again, metrics should not change
Thread.sleep(100);
assertThat(
(Long)
TestingMetricUtils.getGauge(
readerOperatorMetricGroup,
"currentEmitEventTimeLag")
.getValue())
.isGreaterThan(0);
.isEqualTo(emitEventTimeLag);
}

private <T> T testReadSplit(
Expand Down
Loading