[core] Support custom data file name prefix #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
help cc @JingsongLi local repository tests success. |
JingsongLi
reviewed
Sep 3, 2024
| @@ -171,6 +171,12 @@ public class CoreOptions implements Serializable { | |||
| .withDescription( | |||
| "Default file compression zstd level. For higher compression rates, it can be configured to 9, but the read and write speed will significantly decrease."); | |||
|
|
|||
| public static final ConfigOption<String> FILE_PREFIX = | |||
| key("file.prefix") | |||
There was a problem hiding this comment.
data-file.prefix
Default value is "data-".
JingsongLi
reviewed
Sep 3, 2024
| @@ -171,6 +171,12 @@ public class CoreOptions implements Serializable { | |||
| .withDescription( | |||
| "Default file compression zstd level. For higher compression rates, it can be configured to 9, but the read and write speed will significantly decrease."); | |||
|
|
|||
| public static final ConfigOption<String> FILE_PREFIX = | |||
There was a problem hiding this comment.
Can you also introduce changelog-file.prefix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add conf
file.prefixto control the file name prefix of data files.Tests
API and Format
Documentation