Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hive] Sync primary-key/partition-key/bucket-id when sync to hms #4038

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

xuzifu666
Copy link
Member

@xuzifu666 xuzifu666 commented Aug 22, 2024

Purpose

Linked issue: close #xxx

Follow up #3973
currently primary-key partition-key bucket-id not sync to hms, add these info to properties when sync hms.
user condition is to show metadata in platform.

Tests

API and Format

Documentation

@xuzifu666 xuzifu666 closed this Aug 22, 2024
@xuzifu666 xuzifu666 reopened this Aug 22, 2024

// add primary-key, partition-key, bucket-id to tblproperties
if (!tableSchema.primaryKeys().isEmpty()) {
tblProperties.put("primary-key", String.join(",", tableSchema.primaryKeys()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use CoreOptions keys

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminder,Done @JingsongLi

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 1b19183 into apache:master Aug 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants