[migrate] Support migrate table with specific separator #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Aug 19, 2024
| @@ -63,7 +63,7 @@ We can add our table properties while importing by sys.migrate_table('<database> | |||
| <tableproperties> here should be separated by ",". For example: | |||
|
|
|||
| ```sql | |||
| CALL sys.migrate_table('hive', 'my_db.wait_to_upgrate', 'file.format=orc,read.batch-size=2096,write-only=true') | |||
| CALL sys.migrate_table('hive', 'my_db.wait_to_upgrate', 'file.format=orc,read.batch-size=2096,write-only=true', ',') | |||
There was a problem hiding this comment.
maybe it is better to introduce options_map, this arguement is standard SQL map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Support migrate table with specific separator
Currently options in migrate table only support separate by "," which cannot hold all conditions，such as if user want to set option like 'orc.encrypt' = 'pii:id,name' to do orc encrypt condition，this pr is aim to support with specific separator in options separate when call migrate_table.
ParameterUtils##parseCommaSeparatedKeyValues only separate keyValues with comma.
Tests
API and Format
Documentation