[core] fix skew bug of stream read unware bucket table #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
force-pushed
the
fix_skew_bug_of_stream_read_unware_bucket_table_0813
branch
from
4b1efe3 to
aced230
Compare
JingsongLi
reviewed
Aug 14, 2024
| return Tuple2.of(dataSplit.partition(), dataSplit.bucket()); | ||
| }) | ||
| .transform(name + "-Reader", typeInfo, new ReadOperator(readBuilder)); | ||
| if (shuffleByPartition) { |
There was a problem hiding this comment.
You really want this? The streaming-read.shuffle-by-partition is true by default. It means?
There was a problem hiding this comment.
In my business scenario, I will set streaming-read.shuffle-by-partition to false.
I'm not sure if any users need shuffle by partition when read the unware bucket table. So for compatibility reasons, I add this if.
There was a problem hiding this comment.
This is bug, you should fix it.
JingsongLi
reviewed
Aug 14, 2024
...n-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/AppendOnlyTableITCase.java
Outdated
Show resolved
Hide resolved
wwj6591812
force-pushed
the
fix_skew_bug_of_stream_read_unware_bucket_table_0813
branch
from
aced230 to
ef0ab81
Compare
wwj6591812
force-pushed
the
fix_skew_bug_of_stream_read_unware_bucket_table_0813
branch
from
ef0ab81 to
b0c1360
Compare
JingsongLi
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when stream read a unware bucket table with comsume_id and consumer.mode = exactly-once. SKEW will happy, this is a bug, now fix it.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation