-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core]IcebergConversions addType for Timestamp and Time #3866
Conversation
paimon-core/src/main/java/org/apache/paimon/iceberg/manifest/IcebergConversions.java
Outdated
Show resolved
Hide resolved
paimon-core/src/test/java/org/apache/paimon/iceberg/IcebergDataTypeCompatibilityTest.java
Outdated
Show resolved
Hide resolved
PostgresSyncTableActionITCase.testOptionsChange » Timeout testOptionsChange() |
paimon-core/src/main/java/org/apache/paimon/iceberg/manifest/IcebergConversions.java
Outdated
Show resolved
Hide resolved
paimon-core/src/test/java/org/apache/paimon/iceberg/IcebergCompatibilityTest.java
Outdated
Show resolved
Hide resolved
paimon-core/src/test/java/org/apache/paimon/iceberg/IcebergCompatibilityTest.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/iceberg/manifest/IcebergConversions.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/iceberg/manifest/IcebergConversions.java
Outdated
Show resolved
Hide resolved
paimon-core/src/test/java/org/apache/paimon/iceberg/IcebergCompatibilityTest.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/iceberg/manifest/IcebergConversions.java
Outdated
Show resolved
Hide resolved
@tsreaper please Review code again,thanks |
@tsreaper Could you please help me take a look when you have time? Thank you |
paimon-core/src/main/java/org/apache/paimon/iceberg/manifest/IcebergConversions.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/iceberg/manifest/IcebergConversions.java
Outdated
Show resolved
Hide resolved
paimon-core/src/test/java/org/apache/paimon/iceberg/IcebergCompatibilityTest.java
Show resolved
Hide resolved
# Conflicts: # paimon-core/src/main/java/org/apache/paimon/iceberg/manifest/IcebergConversions.java # paimon-core/src/test/java/org/apache/paimon/iceberg/IcebergCompatibilityTest.java
# Conflicts: # paimon-core/src/test/java/org/apache/paimon/iceberg/IcebergCompatibilityTest.java
@tsreaper I am reading the source code now and solved this problem. Please review it for me. |
I found that a lot of the core code was written by you. I will learn from you. I think the source code should make me familiar with paimon quickly. I hope this PR will be submitted as soon as possible. I will continue to contribute to the next one. |
Hi @dbac , sorry for keeping you waiting. I've just introduced statistics to Please resolve the conflicts and add tests about timestamp and time to |
# Conflicts: # paimon-core/src/test/java/org/apache/paimon/iceberg/IcebergCompatibilityTest.java
@tsreaper so IcebergConversions time value should int not long. |
@tsreaper |
@tsreaper ? Could you help me review it again? |
Purpose
Linked issue: close #3788
IcebergConversions addType for Timestamp and Time
Tests
IcebergDataTypeCompatibilityTest
API and Format
Documentation