[core] Support TimestampToNumericPrimitiveCastRule in casting #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzifu666
changed the title
JingsongLi
reviewed
Aug 6, 2024
| @Override | ||
| public CastExecutor<Timestamp, Number> create(DataType inputType, DataType targetType) { | ||
| if (inputType.is(DataTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE)) { | ||
| return value -> DateTimeUtils.unixTimestamp(value.getMillisecond()); |
There was a problem hiding this comment.
Please add a case cast to and cast from.
There was a problem hiding this comment.
OK，had added cast to and from in test case @JingsongLi
xuzifu666
force-pushed
the
cast_timestamp_number
branch
from
6883e60 to
80e601a
Compare
JingsongLi
reviewed
Aug 11, 2024
| return value -> DateTimeUtils.unixTimestamp(value.getMillisecond()); | ||
| } else if (inputType.is(DataTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE)) { | ||
| return value -> | ||
| DateTimeUtils.unixTimestamp( |
There was a problem hiding this comment.
For int, short, byte types, should not return long.
There was a problem hiding this comment.
Make sense，due to the number is hundreds million at least that Interge.Max also cannot hold the size，so I change to just handle Bigint condition in targetType and others return null. @JingsongLi
There was a problem hiding this comment.
And CastRulePredicate should be only target to int and bigint
There was a problem hiding this comment.
Yes，should support int and bigint，I would change it latter. Thanks for the reminder. @JingsongLi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Follow up #3832 had support NumericPrimitive to Timestamp casting，this pr support Timestamp to NumericPrimitive casting.
Linked issue: close #xxx
Tests
CastExecutorTest##testTimestampToNumeric
API and Format
Documentation