[core] Move commit callbacks from TableCommit into FileStoreCommit #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently
CommitCallbacks are called inTableCommitImpl. However as many places directly useFileStoreCommitImplinstead ofTableCommitImpl, commit callbacks won't be called for these usages.In this PR we move commit callbacks from
TableCommitintoFileStoreCommit, so in all scenarios commit callbacks can be called.Tests
This is a code refactor. Existing tests should cover this change.
API and Format
No API / format changes.
Documentation
No new feature.