[core] Introduce CachingCatalog #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
force-pushed
the
cache_catalog
branch
from
fb989b5 to
cbd35ce
Compare
JingsongLi
force-pushed
the
cache_catalog
branch
from
4ae1282 to
a3e19b4
Compare
Zouxxyy
reviewed
Jul 30, 2024
| } | ||
| } | ||
|
|
||
| private void invalidateTable(Identifier identifier) { |
There was a problem hiding this comment.
We can expose the method. For example, Spark TableCatalog has an interface which should uses it
/**
* Invalidate cached table metadata for an {@link Identifier identifier}.
* <p>
* If the table is already loaded or cached, drop cached data. If the table does not exist or is
* not cached, do nothing. Calling this method should not query remote services.
*
* @param ident a table identifier
*/
default void invalidateTable(Identifier ident) {
}There was a problem hiding this comment.
Good point, fixed.
Zouxxyy
approved these changes
Jul 30, 2024
yuzelin
reviewed
Jul 30, 2024
| .booleanType() | ||
| .defaultValue(true) | ||
| .withDescription( | ||
| "Controls whether the catalog will cache table entries upon load."); |
There was a problem hiding this comment.
entries should be more detailed. CacheCatalog caches tables and databases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce a caching catalog, it is enabled by default, and its expiration interval is 30 s.
This can effectively reduce interaction with the metastore and lower the pressure on the metastore.
This is based on #3824
Tests
API and Format
Documentation