Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spark] Support global options via SQL conf #3825

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

Zouxxyy
Copy link
Contributor

@Zouxxyy Zouxxyy commented Jul 28, 2024

Purpose

Users can configure paimon option globally via spark.paimon.x, e.g.

set spark.paimon.file.block-size=512M to control the file block size globally

Tests

API and Format

Documentation

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just using paimon.xxx?

@Zouxxyy
Copy link
Contributor Author

Zouxxyy commented Jul 28, 2024

Why not just using paimon.xxx?

Spark will only recognize sql conf starting with spark.

@Zouxxyy
Copy link
Contributor Author

Zouxxyy commented Jul 28, 2024

For example, if we want to configure hadoop conf to spark, we need to set like spark.hadoop.x

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after test pass.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@YannByron YannByron merged commit 4189a23 into apache:master Jul 30, 2024
9 checks passed
@Zouxxyy Zouxxyy deleted the dev/support-conf branch July 30, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants