[core] Introduce IcebergCommitCallback to create Iceberg metadata after commit #3731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Jul 11, 2024
| @@ -145,23 +145,24 @@ private Predicate convertLeaf(PredicateLeaf leaf) { | |||
| DataType columnType = columnTypes.get(idx); | |||
| switch (leaf.getOperator()) { | |||
| case EQUALS: | |||
| return builder.equal(idx, toLiteral(columnType, leaf.getLiteral())); | |||
There was a problem hiding this comment.
Please create a separate PR for this.
JingsongLi
approved these changes
Jul 12, 2024
| /** Path factory for Iceberg metadata files. */ | ||
| public class IcebergPathFactory { | ||
|
|
||
| private final Path root; |
There was a problem hiding this comment.
just store metadataDirectory? to avoid exposing root to the entire class
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Iceberg is a popular data lake format. In order to have more users try out Paimon while keeping their existing Iceberg workflow, we introduce
IcebergCommitCallbackin this PR to create Iceberg metadata after commit.With this feature, Iceberg readers can read Paimon's
RawFiles.Tests
API and Format
No changes in Paimon format.
Documentation
Yes. Document will be added later.