Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Throw more clear exception for rescale bucket -1 #3589

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

yuzelin
Copy link
Contributor

@yuzelin yuzelin commented Jun 24, 2024

Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

@@ -524,6 +529,18 @@ public static void checkAlterTableOption(String key) {
}
}

public static void checkAlterBucket(int oldValue, int newValue) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to checkAlterTableOption?

@yuzelin yuzelin force-pushed the alert_rescale_bucket branch from 4745bdc to aa65aac Compare June 25, 2024 11:50
@JingsongLi JingsongLi force-pushed the alert_rescale_bucket branch from aa65aac to fef1098 Compare August 21, 2024 05:17
@JingsongLi
Copy link
Contributor

+1

@JingsongLi JingsongLi merged commit 24d8a3b into apache:master Aug 21, 2024
9 of 10 checks passed
@yuzelin yuzelin deleted the alert_rescale_bucket branch November 15, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants