[core] [bug] Partition should not be filtered when manifest file predicate and file itself all min/max is null #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file all values is null
leaves12138
changed the title
added 2 commits
May 29, 2024 09:53
leaves12138
changed the title
JingsongLi
reviewed
May 29, 2024
|
See |
|
See |
added 2 commits
May 29, 2024 11:31
|
FileStoreLookupFunction.createSpecificPartFilter |
|
PredicateBuilder.partition(Map<String, String> map, RowType rowType) |
JingsongLi
reviewed
May 29, 2024
| Object maxValue = stats.max(); | ||
|
|
||
| min[i] = minValue == null ? builder.isNull(i) : builder.greaterOrEqual(i, minValue); | ||
| max[i] = maxValue == null ? builder.isNull(i) : builder.lessOrEqual(i, maxValue); |
There was a problem hiding this comment.
Seems wrong logic here.
Collector should not collect null values.
There was a problem hiding this comment.
I see, if it is null, all values are null.
|
+1 |
leaves12138
added a commit
to leaves12138/incubator-paimon
that referenced
this pull request
May 30, 2024
leaves12138
added a commit
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation