[core] Allow FileIndexer to seek and skip if they need to. #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
changed the title
leaves12138
changed the title
JingsongLi
reviewed
Jun 3, 2024
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexer.java
Outdated
Show resolved
Hide resolved
leaves12138
changed the title
JingsongLi
reviewed
Jun 17, 2024
| @@ -29,7 +31,8 @@ public interface FileIndexer { | |||
|
|
|||
| FileIndexWriter createWriter(); | |||
|
|
|||
| FileIndexReader createReader(byte[] serializedBytes); | |||
| FileIndexReader createReader( | |||
| SeekableInputStream inputStream, Pair<Integer, Integer> startAndLength); | |||
leaves12138
force-pushed
the
read_inputstream
branch
from
879def1 to
7d52e89
Compare
leaves12138
force-pushed
the
read_inputstream
branch
from
7d52e89 to
9d9859f
Compare
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Give
SeekablePositionedMappingInputStreamto FileIndexer, allow them to skip to specified position if they need to.