Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flink] Introduce file index rewriter procedure #3391

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

leaves12138
Copy link
Contributor

@leaves12138 leaves12138 commented May 24, 2024

Purpose

Add / Drop / Modify file index for existing tables.

This action is strictly idempotent.

Trigger this procedure will:

  1. If ManifestFile does not contain the target file index column and type, add it
  2. If ManifestFile contains the index column and type, but table options don't, drop it
  3. If ManifestFile contains the index column and type, and table options also contain, leave it

Tests

API and Format

Three options:

  1. Table name
  2. Partition filter

sql

CALL sys.file_index_rewrite('default.T'); -- just rewrite all the table

CALL sys.file_index_rewrite('default.T', 'pt=a'); --add partition filter

Documentation

@leaves12138 leaves12138 marked this pull request as draft May 24, 2024 08:50
@leaves12138 leaves12138 marked this pull request as ready for review May 27, 2024 01:50
@leaves12138 leaves12138 requested a review from JingsongLi May 27, 2024 08:31
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write document first.

@JingsongLi
Copy link
Contributor

CALL sys.file_index_rewrite('default.T', 'pt=a', 'file-index.bloom-filter.columns=''k'', xxx=xxx');

We don't need to support this now.

@leaves12138 leaves12138 force-pushed the file_index_rewrite_procedure branch from 4185fc4 to ef5b4a4 Compare June 18, 2024 02:24
@leaves12138 leaves12138 requested a review from JingsongLi June 18, 2024 10:03
@leaves12138
Copy link
Contributor Author

CALL sys.file_index_rewrite('default.T', 'pt=a', 'file-index.bloom-filter.columns=''k'', xxx=xxx');

We don't need to support this now.

Removed

@leaves12138
Copy link
Contributor Author

Please write document first.

Added document

JingsongLi pushed a commit to leaves12138/incubator-paimon that referenced this pull request Jun 20, 2024
@JingsongLi JingsongLi force-pushed the file_index_rewrite_procedure branch from 59f45f0 to 200d0b1 Compare June 20, 2024 06:56
@JingsongLi JingsongLi force-pushed the file_index_rewrite_procedure branch from 200d0b1 to 1b65956 Compare June 20, 2024 07:45
@JingsongLi
Copy link
Contributor

+1

@JingsongLi JingsongLi merged commit 7524767 into apache:master Jun 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants