[core] Incremental-between tags should deduplicate records #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
reviewed
May 16, 2024
| split.dataFiles(), | ||
| split.deletionFiles().orElse(null), | ||
| true)); | ||
| if (split.isStreaming() || split.convertToRawFiles().isPresent()) { |
There was a problem hiding this comment.
split.rawConvertible()?
There was a problem hiding this comment.
maybe we can write like this:
if (split.rawConvertible()) {
return createNoMergeReader(
split.partition(),
split.bucket(),
split.dataFiles(),
split.deletionFiles().orElse(null),
false);
} else {
return createMergeReader(
split.partition(), split.bucket(), split.dataFiles(), null, forceKeepDelete);
}
If split.isStreaming() then split.rawConvertible() must be true. If rawConvertible, then no need to merge, we can filter the whole value.
There was a problem hiding this comment.
We can ignore rawConvertible, it will use RawFileSplitRead.
sunxiaojian
pushed a commit
to sunxiaojian/paimon
that referenced
this pull request
May 28, 2024
JingsongLi
added a commit
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3310
Tests
API and Format
Documentation