[core] Move the hilbert dependencies to paimon-common module #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you show the jar changing? How much has the size of paymon-common.jar increased? |
Before the modification, the size of paimon-common-0.8-SNAPSHOT.jar was 3.7M. Dependencies related to the hilbert-curve will be added to the jar, as shown in the figure:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Move the hilbert dependencies to paimon-common module.
Linked issue: close #3250
Tests
I have conducted end-to-end testing and confirmed that the jar packaged in the
paimon-flink/paimon-flink-1.17module contains the necessary dependencies